search

jtblin / kube2iam

kube2iam provides different AWS IAM roles for pods running on Kubernetes
BSD 3-Clause "New" or "Revised" License
1.98k stars 319 forks source link

Deal with duplicated IP in the pod cache #252

Closed ltagliamonte-dd closed 4 years ago

ltagliamonte-dd commented 4 years ago

Trying to definitely fix issue https://github.com/jtblin/kube2iam/issues/244 maintaining retro compatibility.

When the flag is set to true (default is false) in case the cache lookups returns more than 1 result, a query to the API server is issued and a pod is returned only if it is running and not with host network.

I've also added some metrics in order to track the amount of requests that are performed to the api server.

@Jacobious52 or any other maintainers can you please check this out?

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 19.481% when pulling 4654208ad42500f6c289cb44b7b26da383e6e939 on ltagliamonte-dd:master into 796b988765a075548cbcb1af4a9fc05b4adc8588 on jtblin:master.

ltagliamonte-dd commented 4 years ago

@Jacobious52 @jtblin any updates on this PR?

ltagliamonte-dd commented 4 years ago

@Jacobious52 or @SharpEdgeMarshall do any of you have available cycles to look at this? I'd really like to get a review and get this in for everyone.

ltagliamonte-dd commented 4 years ago

Can someone please review this PR? @struz @SharpEdgeMarshall @Jacobious52 @jtblin @jrnt30 ?

SharpEdgeMarshall commented 4 years ago

lgtm

ltagliamonte-dd commented 4 years ago

Can someone please review and merge this PR? @struz @Jacobious52 @jtblin @jrnt30 ?

ltagliamonte-dd commented 4 years ago

I'm happy to work on any change that can help this to get merged. Thanks. @Jacobious52 @jtblin

ltagliamonte-dd commented 4 years ago

@mwhittington21 thank you for the review I've addressed all you suggestions via 4654208

Looking forward to see this merged and released. Thank you for you time!

You can squash all commits on merge using: select-squash-and-merge-from-drop-down-menu