jtblin / kube2iam

kube2iam provides different AWS IAM roles for pods running on Kubernetes
BSD 3-Clause "New" or "Revised" License
1.97k stars 318 forks source link

Adopt the helm chart? #277

Closed davidkarlsen closed 3 years ago

davidkarlsen commented 3 years ago

Please see https://github.com/helm/charts/issues/21103 The helm stable repo is about to shut down. Would you be interested in maintaining the chart here? We have tooling like shown in https://github.com/helm/charts-repo-actions-demo to support a workflow for testing and releasing charts. Visibility on the Helm Hub is done through https://github.com/helm/hub CC @scottrigby

scottrigby commented 3 years ago

Note that Nov 13, 2020 the stable repo will be unsupported.

mariusv commented 3 years ago

@davidkarlsen if nobody is interested I can pick this one up and maintain it as I'm using it on a daily basis on about 10 clusters CC @scottrigby

scottrigby commented 3 years ago

I just pinged @jtblin on Slack and by email in case this was missed. One note: if @jtblin agrees to host it under their github username just like the project is, the chart could be marked "official" in the CNCF Artifact Hub https://artifacthub.io/

jtblin commented 3 years ago

Yes I'm happy to host it, however I do not have much time to maintain it so I'd love to enlist @mariusv help for that.

mariusv commented 3 years ago

Awesome, I'll do a PR with the chart and add it to the chart directory ? Or you prefer any other path @jtblin ?

scottrigby commented 3 years ago

@mariusv I would suggest following similar steps as I did for the prometheus-community charts: https://github.com/prometheus-community/helm-charts/issues/3 (this brings git history into your repo). For directory, /charts is a good choice if you have no reason to change it (this is the default for chart-testing).

Then, as @davidkarlsen said in https://github.com/jtblin/kube2iam/issues/277#issue-675581486 you can emulate the GitHub Actions in the demo repo for CI/CD. If you'd like help with that please let me know 😄

jtblin commented 3 years ago

Awesome, I'll do a PR with the chart and add it to the chart directory ? Or you prefer any other path @jtblin ?

@mariusv PR is great 👍

benfrench1 commented 3 years ago

Hi @jtblin and @mariusv , hope you are well. I have a silly question....where is the proposed new location for the kube2iam helm chart? Can you post the link please, that would be much appreciated 😄. Many thanks

denniswebb commented 3 years ago

@jtblin I'm open to doing the PR for the chart. Where were you planning on hosting the packaged chart? Just a GitHub pages site?

dan-slinky-ckpd commented 3 years ago

Any update on this? As per the deprecation timeline, the chart repos will likely be garbage collected and no longer available from Friday 13th November 2020 - happy to help contribute.

mariusv commented 3 years ago

@dan-slinky-ckpd PR is here. We need @jtblin to create the Github pages to be able to host the chart

mariusv commented 3 years ago

@jtblin I can enable github pages on my fork if you want but I guess you'd rather do this under this repo

zhimsel commented 3 years ago

This should be reopened. The chart itself was migrated here, but there is no repo yet set up to host it.

mariusv commented 3 years ago

@zhimsel good catch. Added a new PR to fix the README issues #289

mariusv commented 3 years ago

@jtblin could you please enable Github Pages so I can push the chart in there? I can also enable it on my repo but would rather have it here

mariusv commented 3 years ago

@jtblin this is what needs to be done

benfrench1 commented 3 years ago

Is there any update on this :)

jtblin commented 3 years ago

Ok, I've completed the configuration and triggered a release event. It seems to have created http://jtblin.github.io/kube2iam/index.yaml, is that all that's needed?

chadlwilson commented 3 years ago

Thanks a lot @jtblin - it seems to be working via helm fetch kube2iam --repo http://jtblin.github.io/kube2iam so I guess updating the README and such for a new version via #289 is all that is required here now.