search

jtblin / kube2iam

kube2iam provides different AWS IAM roles for pods running on Kubernetes
BSD 3-Clause "New" or "Revised" License
1.97k stars 318 forks source link

the latest docker tags seems incorrect to docker convention #297

Open jetersen opened 3 years ago

jetersen commented 3 years ago

the latest docker tag is mistakenly using the chart tag.

Looking at the tag diff there are no changes to the image.

The values.yaml file is using this: https://github.com/jtblin/kube2iam/blob/c24c3c8feb7f798e045c5191c384da6f341de93c/charts/kube2iam/values.yaml#L40

mariusv commented 3 years ago

Hi @jetersen ,

Not really sure I understand. The chart default values.yaml is using a old docker image. I'd suggest you add whatever docker image you want in your deployment

jetersen commented 3 years ago

This is the docker tag in question: https://hub.docker.com/layers/jtblin/kube2iam/kube2iam-2.5.2/images/sha256-aef3befd35d816e9cb8418a4be0f199ab734730b07eac95024a4b4332b789205?context=explore

based on the previous github tag: https://github.com/jtblin/kube2iam/releases/tag/0.10.11 I would expect the next docker tag to be 0.10.12 or 0.11.0 or 1.0.0.

walkafwalka commented 3 years ago

I see what you mean @jetersen.

Previously, GitHub releases were 0.10.9, 0.10.10, 0.10.11, etc. and those GitHub releases correlated to Docker tags in DockerHub. Now that the chart version is also being released in GitHub releases, DockerHub is picking up those tags.

@jtblin, I think we should define a prefix to different kube2iam releases and releases for the kube2iam chart. Then we should only publish tags to DockerHub that correlate with kube2iam releases, not the chart releases.