search

jtblin / kube2iam

kube2iam provides different AWS IAM roles for pods running on Kubernetes
BSD 3-Clause "New" or "Revised" License
1.98k stars 319 forks source link

Helm chart using old Docker tag #306

Open cablespaghetti opened 3 years ago

cablespaghetti commented 3 years ago

Hi,

It seems that the Helm chart is still using the 0.10.9 docker tag. Is there a reason for this, or should I raise a PR to upgrade it to kube2iam-2.6.0 which seems to be the latest release?

Thanks

FrederikNJS commented 3 years ago

It would seem that there's some confusion with the versions (see #297). 2.6.0 is the version of the helm chart, not kube2iam. There are still newer kube2iam releases though, such as 0.10.11

cablespaghetti commented 3 years ago

Interesting, that isn't clear on the github releases. Thanks to @mariusv for making that commit.

The reason I care is that the kube2iam-2.6.0 docker tag is multi-arch and support ARM64 processors whereas 0.10.11 does not.

robinverduijn commented 3 years ago

We are having an issue with the older Docker tag specified in the Helm chart as well. Locally, we've resorted to specifying a newer tag so that we can get the fixes from https://github.com/jtblin/kube2iam/pull/270.

We had been specifying tag: kube2iam-2.6.0 as well; based on this conversation it sounds like perhaps tag: 0.10.11 should work as well but either way, it would be nice if the upstream chart here provided the Docker image with the most recent fixes so people don't have to pin it to a newer version on their end. Rather than 0.10.9 which is missing some of the crucial (for us) IMDSv2 fixes.

ahmsb8884 commented 3 years ago

team, I have used 10.11 and 2.6 container in my helm chart and still am observing these errors in logs calling IMDS time="2021-08-13T19:19:19Z" level=error msg="Error getting instance id Get \"http://169.254.169.254/latest/meta-data/instance-id\": dial tcp 169.254.169.254:80: i/o timeout"

which version should I use?

ypicard commented 2 years ago

Could we get some clarifications on this?