search

jtbm37 / all-the-icons-dired

Adds dired support to all-the-icons
GNU General Public License v3.0
197 stars 26 forks source link

Use overlay for displaying icons #21

Closed buzztaiki closed 4 years ago

buzztaiki commented 5 years ago

Use overlay's before-string property for displaying icons instead of inserting text with face.

This PR will fix following problems:

seagle0128 commented 5 years ago

Unhelpful dependence on font-lock+ (now font-lock+ is not exists on melpa).

all-the-icons-dired requires font-lock+? I didn't see any codes there.

buzztaiki commented 5 years ago

all-the-icons-dired requires font-lock+? I didn't see any codes there.

all-the-icons-dired does not require font-lock+, but all-the-icons has required font-lock+'s font-lock-ignore property before. See https://github.com/domtronn/all-the-icons.el/pull/106.

conao3 commented 4 years ago

This patch is needed. Any dired related packages should not modify dired text (this causes breaks other packages easily). How about @jtbm37 ? This patch is sended a long time ago.

seagle0128 commented 4 years ago

One problem: the icons won't disappear after deleting some files.

conao3 commented 4 years ago

hmm, maybe we refresh overlays some timing after dired buffer refreshes each.

wyuenho commented 4 years ago

This PR is no longer needed right?

buzztaiki commented 4 years ago

I think #24 have fixed all problems of this PR. Tnanks @conao3.