search

jtbm37 / all-the-icons-dired

Adds dired support to all-the-icons
GNU General Public License v3.0
197 stars 26 forks source link

refactor code base and add custom icon args options. #26

Closed mohkale closed 4 years ago

mohkale commented 4 years ago

I've seperated icon-selection from icon-insertion, removed a lot of the repetitive configurations arguments in the calls to the all-the-icon-* functions, and added a new option all-the-icons-dired-icon-args allowing users to specify the arguments they want to pass to all-the-icons.

This initially started off just because I wanted to specify the height of the icons, but to do so I'd have to edit 5 different locations. Now I just need to customise one variable.

I've also inadvertently reindented the code base, because evil-return auto indents to the recommended indent specifications; I also found this new indentation scheme more readable so I hope this won't be an issue. If there was some logical reason for the old approach, I'm open to reverting it (as best I can).

wyuenho commented 4 years ago

This PR is no longer needed right?

mohkale commented 4 years ago

Yeah, though it'd still be nice to have the option to let end users decide what icons should be assigned to what files. I'll have to start again from the head of the master branch tho.