Use tab as spacer - Githubissues

jtbm37 / all-the-icons-dired

Adds dired support to all-the-icons

GNU General Public License v3.0

197 stars 26 forks source link

Closed conao3 closed 4 years ago

conao3 commented 4 years ago

Use tab as spacer. This PR solves #29.

conao3 commented 4 years ago

Screenshot_2020-03-01_13-32-07 left is before, right is dired after merged this PR. But plain file icon is not aligned...?

conao3 commented 4 years ago

Screenshot_2020-03-01_13-48-52

left is dired before this PR merged.
middle is dired after this PR merged.
right is dired after this PR merged and domtronn/all-the-icons.el/pull/186 merged.

seagle0128 commented 4 years ago

@conao3 Thank you for porting the trick from Centaur Emacs. That does work well according to my testing.

One minor issue, I notice the colors of directories and some files are incorrect with #24. Can you please check that?

conao3 commented 4 years ago

OK, I'll check it later.

[UPDATE] ... and I'll send another PR to solve that issue. This PR can be merged since solving the problem of the target.

conao3 commented 4 years ago

@seagle0128 #32 solves the directory face issue. Please check it!

conao3 commented 4 years ago

ping @jtbm37 ?

seagle0128 commented 4 years ago

I can confirm it does work well. Please merge, @jtbm37 . Thank you!

conao3 commented 4 years ago

ping? This PR is needed for beautiful showing icons in dired!

jtbm37 commented 4 years ago

@conao3 Thanks!

conao3 commented 4 years ago

Thanks!