search

jtbm37 / all-the-icons-dired

Adds dired support to all-the-icons
GNU General Public License v3.0
197 stars 26 forks source link

apply new *-icon-for-dir API and use *-dired-dir-face #32

Closed conao3 closed 4 years ago

conao3 commented 4 years ago

This PR solves dir face issue which is mentioned at https://github.com/jtbm37/all-the-icons-dired/pull/31#issuecomment-593062849 . But this PR depends PR sent all-the-icons (domtronn/all-the-icons.el/pull/181). So, this PR send as WIP PR until the PR merged.

conao3 commented 4 years ago

Screenshot_2020-03-01_23-53-10

conao3 commented 4 years ago

pass all-the-icons-dired-v-adjust to all-the-icons-icon-for-dir as override arg.

[Note] Do we need to adjust :v-adjast or :font in each package like this? If we need to make these tweaks, we can modify upstream and get its contributions in many packages.

seagle0128 commented 4 years ago

Do we need to adjust :v-adjast or :font in each package like this? If we need to make these tweaks, we can modify upstream and get its contributions in many packages.

@conao3 Actually I submitted the PR https://github.com/domtronn/all-the-icons.el/pull/173. The maintainer thinks it's hard to adapt all fonts. So, the args is necessary here IMO.

conao3 commented 4 years ago

OK, thanks!

conao3 commented 4 years ago

all-the-icons upstream PR is merged :tada: This PR could be mergeable!

jtbm37 commented 4 years ago

@conao3 Thanks!