search

jtbm37 / all-the-icons-dired

Adds dired support to all-the-icons
GNU General Public License v3.0
197 stars 26 forks source link

Icons are not aligned after rename file #34

Open conao3 opened 4 years ago

conao3 commented 4 years ago

Ref: https://github.com/jtbm37/all-the-icons-dired/pull/24#issuecomment-599704468

@conao3 I think there are issues here when renaming a file. When I rename a file the icon ends up on the far left.

seagle0128 commented 4 years ago

Same issue while creating a new file or directory (+).

Updated: I can confirm this solution works well.

    (advice-add 'dired-do-create-files :around #'all-the-icons-dired--refresh-advice)
    (advice-add 'dired-create-directory :around #'all-the-icons-dired--refresh-advice)
shingo256 commented 4 years ago

Hi,

I encountered this issue as well when renaming a file, and found that below two lines look like resolving it.

       (advice-add 'dired-add-entry :around #'all-the-icons-dired--refresh-advice)
       (advice-add 'dired-remove-entry :around #'all-the-icons-dired--refresh-advice)

Hope it would be incorporated in all-the-icons-dired--setup.

seagle0128 commented 3 years ago

I think this issue can be closed.

conao3 commented 3 years ago

Sorry, I've been away from this issue for a bit. Thanks, suggestion. Has this issue been gone, @seagle0128 ?

seagle0128 commented 3 years ago

@conao3 I took a quick look at the codes in this repo. The issue still exists, and the repo seems not to be maintained. I download the package from melpa, the repo has been changed to https://github.com/wyuenho/all-the-icons-dired. This issue has been fix in the forked repo.

conao3 commented 3 years ago

Thanks. Then I'll leave the issue open for the owner of this repository. I hadn't updated the local all-the-icons-dired. Thanks for letting me know that!