search

jtbm37 / all-the-icons-dired

Adds dired support to all-the-icons
GNU General Public License v3.0
197 stars 26 forks source link

all-the-icons-dired--refresh-advice doesn't check `display-graphic-p` #51

Open mohkale opened 3 years ago

mohkale commented 3 years ago

I'm using this package in the terminal and by default icons aren't setup because this condition fails on ttys.

https://github.com/jtbm37/all-the-icons-dired/blob/fc2dfa1e9eb8bf1c402a675e7089638d702a27a5/all-the-icons-dired.el#L125-L131

However all-the-icons-dired--refresh-advice which is hooked into misc dired functions eg. dired-maybe-insert-subdir doesn't check this condition so when you run it icons are forcefully inserted.

srustamo commented 2 years ago

@mohkale did you get this package work in tty? I see the icons, but they are all wrong in iTerm2 on macos.

mohkale commented 2 years ago

@srustamo

I use nerd-fonts, and replace some all-the-icons fonts with nerd-fonts. See here.