search

jtbm37 / all-the-icons-dired

Adds dired support to all-the-icons
GNU General Public License v3.0
197 stars 26 forks source link

all-the-icons-dired--refresh-advice doesn't check `display-graphic-p` #52

Closed mohkale closed 3 years ago

mohkale commented 3 years ago

closes #51

wyuenho commented 3 years ago

This check is probably not necessary anyway since all-the-icons are backed by an icon font. Either your terminal has the font patched to display these icons or it doesn't. In any case, this check should be done in init.el by the user themselves.

mohkale commented 3 years ago

@wyuenho

Fair enough. I can get the same affect as this patch by just adding a :if to use-package so I see no issue with this approach. Thank you.

wyuenho commented 3 years ago

That's exactly what I do :)