jtbray / brilliant-resume

Grav theme designed for professionals to showcase their talent, work & experience.
MIT License
14 stars 5 forks source link

Removing toolbar from portfolio viewing error mobile #3

Closed jpitcairn closed 6 years ago

jpitcairn commented 6 years ago

Thanks for making this theme. Suits my needs almost perfectly.

Just one small query/issue. Trying to remove the toolbar from the portfolio item view.

I've removed the below code from the twig file and changed the .macbook .screen .browser .contentheight to 100%

<div class='toolbar'>
                <div class='row_one'>
                  <div class='dot'></div>
                  <div class='dot'></div>
                  <div class='dot'></div>
                </div>
                <div class='row_two'>
                  <div class='nav'>
                    <div class='prev'>&laquo;</div>
                    <div class='next'>&raquo;</div>
                  </div>
                  <div class='search_bar'></div>
                </div>
              </div>

This works on desktop but breaks on mobile.

screen shot 2018-09-06 at 11 28 48 screen shot 2018-09-06 at 11 36 25

Am I missing something in the theme?

jtbray commented 6 years ago

I'm glad you're enjoying the theme!

I just pushed a few changes & updates, which will fix the issue you're experiencing.

I added a toggle in the portfolio item admin pages to "Show toolbar mockup" which will when disabled will not display the toolbar, and updated the css so that you won't have any whitespace.

One thing, please don't edit the Twig otherwise you're changes will be overridden when I push changes & updates (as with any theme), just open an issue like you did & I'll get to it as quickly as possible.

I'd love to see your site when it's completed so don't forget to send me a link!

Thanks,

Jason