search

jtburgess / indigo-TP-LInk

Indigo Plugin for TP-Link SmartPlugs, powerStrips, dimmer switches, and dimmable bulbs; (coming someday color bulbs)
The Unlicense
2 stars 4 forks source link

Changing the dev.description field (Notes) #4

Closed indigodomo closed 3 years ago

indigodomo commented 4 years ago

I'd recommend that you not overwrite the description (Notes) field on a device as you do in lines 152-155. Populating it at creation time is OK - but that field is really there for users to keep notes about a device (location, use, etc). Overwriting it every time the device starts up is going to confuse users (like me!) because my changes don't "stick".

jtburgess commented 3 years ago

I didn't see this until after I committed. I'll fix it with the next check-in.

jtburgess commented 3 years ago

Jay (I assume). I think this is fixed in the latest code.
I update dev.description in deviceStartComm(), ONLY if len(dev.description) == 0. Will that work for you? Is there a better place to do it?

-- John

indigodomo commented 3 years ago

That seems like a reasonable implementation.

jtburgess commented 3 years ago

Jay? Matt? Try downloading tag 0.9.2. I haven’t packaged it for indigo release yet, But I’d like you to try it out, and give me feedback. Like, will I need to create a different subtype for colored bulbs, And what base class should I use?

https://github.com/jtburgess/indigo-TP-LInk/tree/0.9.2

Thanks!

I’m away for a week, then I’ll create a 1.0 release.

-- John

On Jan 23, 2021, at 12:45 PM, Indigo Domotics notifications@github.com wrote:

 That seems like a reasonable implementation.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

indigodomo commented 3 years ago

Hi John,

I'm just wrapping up a move - I'll try it out when I get a chance.

jay

On Jan 23, 2021, at 7:27 PM, John Burgess notifications@github.com wrote:

Jay? Matt? Try downloading tag 0.9.2. I haven’t packaged it for indigo release yet, But I’d like you to try it out, and give me feedback. Like, will I need to create a different subtype for colored bulbs, And what base class should I use?

https://github.com/jtburgess/indigo-TP-LInk/tree/0.9.2

Thanks!

I’m away for a week, then I’ll create a 1.0 release.

-- John

On Jan 23, 2021, at 12:45 PM, Indigo Domotics notifications@github.com wrote:

 That seems like a reasonable implementation.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jtburgess/indigo-TP-LInk/issues/4#issuecomment-766272040, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABMS3VVGQSBO2MJMOF4324LS3NZR3ANCNFSM4N2W6O7Q.

jtburgess commented 3 years ago

Resolved in tag 0.9.3