search

jtdaugherty / vty

A high-level ncurses alternative written in Haskell
BSD 3-Clause "New" or "Revised" License
319 stars 57 forks source link

cleanup: Make ScopedTypeVariables explicit in files that use it. #237

Closed iphydf closed 2 years ago

iphydf commented 2 years ago

I like to make it so files can be copied into other projects with minimal effort, especially for tests, because those are the ones I tend to copy from when learning how a library should be used. Generally, I like to be explicit in each file what extensions are used.

It seems the intention here was to pretend that ScopedTypeVariables is a standard Haskell feature. I disagree with that intention, but if that's the repo's intention, feel free to close this PR.

jtdaugherty commented 2 years ago

I suspect the intention was just to make using the extension more convenient by not having to repeat the pragma everywhere, but I don't know for sure since that code was written by others. But I also have a personal preference never to put extensions in the cabal file like this as well, although for a slightly different reason - I think having the extensions spelled out explicitly helps with readability since nothing is implicitly turned on elsewhere and thus hidden. Thanks for this change!