search

jtdor / build-deb-action

GitHub action for building Debian packages with dpkg-buildpackage.
MIT License
25 stars 11 forks source link

Did not find the .buildinfo file in debian/files #3

Closed r4sas closed 1 year ago

r4sas commented 1 year ago

Hello. I'm using your action to build testing packages for our project. Since yesterday, when 1.6.0 was released, action started failing at artifacts moving:

Did not find the .buildinfo file in debian/files at /github/action/scripts/move_artifacts line 35.

Example run: https://github.com/PurpleI2P/i2pd/actions/runs/4247105073/jobs/7384748674#step:3:1311 Workflow: https://github.com/PurpleI2P/i2pd/actions/runs/4247105073/workflow

Switching back to 1.5.0 fixes issue. Any ideas? Thanks.

jtdor commented 1 year ago

Hi @r4sas, thanks for the report and sorry about the inconvenience.

From a quick look at my changes, I used an incorrect regex to find the name of the .buildinfo file. The name of your package as built from the workflow does contain a +, which this regex (wrongly) does not accept.

That's easily fixable, will do that tomorrow and release a new version.

r4sas commented 1 year ago

FYI, same was when there was no + with previous version of workflow: https://github.com/PurpleI2P/i2pd/actions/runs/4246988979/workflow

jtdor commented 1 year ago

FYI, same was when there was no + with previous version of workflow: https://github.com/PurpleI2P/i2pd/actions/runs/4246988979/workflow

You are right, the error affected any package name and version that contained anything besides a-z, 0-9 and _. The workflow you linked contained a - which unfortunately also made it fail.

Thanks again for the report. Its fixed with version 1.6.1.

For (my own) reference: This was bug introduced with version 1.6.0 and 8f94178.

r4sas commented 1 year ago

Thank you!

r4sas commented 1 year ago

btw, example with before-build-hook is incorrect, because

  1. git is not installs with devscripts
  2. git would reject work with error fatal: detected dubious ownership in repository at '/github/workspace'

before-build-hook: debchange --controlmaint --local="+$(git describe --tags)" "CI build"

jtdor commented 1 year ago

Also thanks for these two hints, @r4sas. Feel free to also open a separate issue for such observations next time.

I added the forgotten dependency to the example and also simplified—well, enabled—the usage of git in the before-build-hook in version 1.7.0.