search

jtebbens / com.homewizard

Homewizard app for Homey
9 stars 7 forks source link

New feature request: offset temperature #60

Closed stevenv2201 closed 2 years ago

stevenv2201 commented 2 years ago

I'm integrating some 868 Mhz Smartwares temperature/humidity sensors via the Homewizard hardware and Homewizard app on my Homey. I noticed that the temperature of one of my sensors deviates with 1°C from the true temperature. Is there a possibility to add an "temperature_offset" functionality in future releases of the homewizard app? Similar to how you can indicate an offset for temperature measurements for temperature sensors added via the "draadloze weersensoren" app?

jtebbens commented 2 years ago

Not sure, have to see the code to understand the effort to add such request.

stevenv2201 commented 2 years ago

I was able to implement this myself. I'm very new to github, don't know if you are able to see my suggested changes

jtebbens commented 2 years ago

Ok nice. Did you test/ run it against your own HomeWizard and Homey?

stevenv2201 commented 2 years ago

Yes I did, see example below. Red = original homewizard app. Purple = with adjusted codes and an offset of -2°C image

jtebbens commented 2 years ago

I merged your code and testing it here locally with my Homewizard/Homey combo. Will push to beta when OK.

jtebbens commented 2 years ago

Ok its in the Homey app store now as test/beta. I'll update the community forum/

https://homey.app/a/com.homewizard/test/

stevenv2201 commented 2 years ago

OK, super! Thanks :-) Steven Verhaeghe

jtebbens commented 2 years ago

Feature has been added as per 2.1.4 and above.