Closed steelejoe closed 11 years ago
Does this work now? The compiled .js file works with the examples?
If so, can you check in the compiled .js files?
whoah.... what did you do here?
Hi Jeff,
The -O2 version is not building yet. There is a problem at the relooper stage. I will test the examples tonight, but I have not yet. Sorry about the pull confusion. I was misresding what github was telling me. I thought you had checked in updates and I was trying to update my fork.
Joe On Jul 21, 2013 8:46 PM, "Jeff Terrace" notifications@github.com wrote:
whoah.... what did you do here?
— Reply to this email directly or view it on GitHubhttps://github.com/jterrace/js.js/pull/5#issuecomment-21323550 .
I see. So should I just close this pull request for now?
If you plan on continuing to work on fixing O2, then you can open a new pull request. If you don't plan to continue working on it, let me know and I'll pull your changes into a branch here and try and find some time to work on finishing it up.
I am still working on -O2 but the fix may be in Emscripten. I would say close this pull request for now and I will open another if/when I manage to fix it. On Jul 22, 2013 8:41 AM, "Jeff Terrace" notifications@github.com wrote:
I see. So should I just close this pull request for now?
If you plan on continuing to work on fixing O2, then you can open a new pull request. If you don't plan to continue working on it, let me know and I'll pull your changes into a branch here and try and find some time to work on finishing it up.
— Reply to this email directly or view it on GitHubhttps://github.com/jterrace/js.js/pull/5#issuecomment-21352769 .
IGNORE THIS - INTENDING TO GO THE OTHER WAY