search

jterrace / pyssim

A Python module for computing the Structural Similarity Image Metric (SSIM)
MIT License
339 stars 62 forks source link

Added CW-SSIM for computing SSIM in complex wavelet domain #12

Closed chaosmail closed 9 years ago

chaosmail commented 9 years ago

Hi guys,

thanks for your nice library! I added SSIM computation in complex wavelet domain (IMAGE SIMILARITY IN COMPLEX WAVELET DOMAIN from Zhou Wang and Eero P. Simoncelli), which is invariant to translation and rotation. I added an IPhython notebook with the examples and benchmarks.

Best, Christoph

jterrace commented 9 years ago

Could you fix the pylint errors? See the README for how to run it.

jterrace commented 9 years ago

Could you also add a command-line flag to use this new algorithm and add a test that uses it in .travis.yml?

chaosmail commented 9 years ago

Alright, I tried to address all your remarks in the last commit.

chaosmail commented 9 years ago

hmm what's going on in the Travis build, there are strange errors. I also added Python 3.4 to the .travis.yml because I am using it on my machine and it works nice; however, there is also some issue in Travis.

chaosmail commented 9 years ago

Alright, I could resolve all the errors; I rebased the PR to a nice commit. Btw. I added conda to Travis, to speed up the tests; also I removed python 3.2 (it should not be used) and added python 3.3 and 3.4 to Travis. I added tests, some description in the README, some command line arguments and the Reference to the paper. Let me know if you need further adjustments ;)

chaosmail commented 9 years ago

I almost forgot; there is also the IPython file in the root folder (comparing the 2 methods) and the PDF paper in the readings folder. Hope that's ok - if not then I will remove them. Best, Christoph

jterrace commented 9 years ago

Yeah, 3.2 was broken at head too. You actually managed to fix the errors? Sweet!

jterrace commented 9 years ago

Just two minor comments and it's ready to merge. Thanks for the contribution!

chaosmail commented 9 years ago

alright, here we go.

jterrace commented 9 years ago

Nice contribution. Thank you!

jterrace commented 9 years ago

Once thing I forgot - will you send me a followup CL to add yourself to the AUTHORS file?