search

jtextor / dagitty

Graphical analysis of structural causal models / graphical causal models.
GNU General Public License v2.0
255 stars 47 forks source link

Use CDN for underscore.js library #74

Closed jeroen closed 7 months ago

jeroen commented 1 year ago

Hi! We plan to remove the bundled underscore.js library from the V8 package. Can you update dagitty to use this library from another source?

jtextor commented 1 year ago

Thanks for the heads-up! I'm a little concerned that this may trip up CRAN because using the package will now require an internet connection. Do you have any experience with this approach? (Longer-term I want to remove underscore.js anyway as it's no longer really necessary but that may take a while)

jeroen commented 1 year ago

Thanks. CRAN is generally OK with using internet sources, but if you really want the package to work offline, you can ship a copy of underscore.js in dagitty, in the same way as we used to do with V8.

jeroen commented 9 months ago

Hello, friendly ping. I'm going to remove underscore.js from V8. So you can either use the CDN as above, or ship a copy of understore.js in dagitty.

THanks!

jtextor commented 7 months ago

I have resolved this in a different way by using webpack, but the dependency is gone now. Hoping to send this to CRAN soon; I seem to be facing some Fedora-specific issues again :(

jeroen commented 7 months ago

What is the fedora specific issue? Maybe I can help?

jtextor commented 7 months ago

I tested the package on r-hub and it gave a JS syntax error that I couldn't replicate anywhere else. I tested it on a Fedora cloud machine and it worked fine. I am thinking that the r-hub system might have some old or broken packages installed, but there's no way for me to check this, so I may try to submit to CRAN anyway (I checked the package on 8 other systems without any problems)

jeroen commented 7 months ago

Yes, I think r-hub uses an outdated version of Fedora, don't worry about it!