search

jtextor / dagitty

Graphical analysis of structural causal models / graphical causal models.
GNU General Public License v2.0
255 stars 47 forks source link

Is it possible to move away from V8 in favor of a liter dependency? Say, `QuickJSR` #81

Open barracuda156 opened 9 months ago

barracuda156 commented 9 months ago

@jtextor V8 is a very heavy dependency to build and it is broken for some platforms. Could we get rid of it? Possibly, replacing with QuickJSR, like rstan did?

jtextor commented 9 months ago

It's an interesting idea, but V8 is very fast and QuickJS seems to be quite a bit slower ... I don't know if that would be a bottleneck or not? Could be an interesting thing to test.

barracuda156 commented 9 months ago

I cannot vouch personally for speed (since V8 is broken for the platform where I test), but given that rstan uses QuickJSR, and rstan is a very sophisticated and speed-wanting software, it should be pretty good.

QuickJSR itself builds quickly, and Stan models work fine. V8 – well, last time I tried to fix it, and went pretty far with that, it took multiple hours before failing on a wrong assembler :) Admittedly, my PowerPC is no TALOSII, but it is a very heavy dependency.

barracuda156 commented 3 months ago

@jtextor Maybe you could make a branch with a switch to QuickJSR? That would fix dagitty without compromising it for those preferring V8.

barracuda156 commented 2 weeks ago

@jtextor Any update on this?