search

jtheoof / swappy

A Wayland native snapshot editing tool, inspired by Snappy on macOS
MIT License
1k stars 40 forks source link

Update README.md #89

Closed ammgws closed 3 years ago

ammgws commented 3 years ago

Since the latest release, JPEG is working when it wasn't before.

At a glance I couldn't spot the commit that changed this, but I assume it is not just by random chance?

jtheoof commented 3 years ago

@ammgws a few issues.

  1. This is not respecting conventional-commits I recommend something like docs(readme): add support for jpg files.
  2. You would also need to update the man page scd file.
  3. You would also need to update the desktop file

Can you update your PR based on that?

ammgws commented 3 years ago

Sure, I was just testing the waters first.

ammgws commented 3 years ago

Think that should do it.

jtheoof commented 3 years ago

Thaks @ammgws

markstos commented 1 year ago

This is good, but nothing in the current README mentions jpeg, or jpg or any mention of which file formats are supported.

After I use swappy, I often paste the PNG into https://squoosh.app/ where it's a converted to a JPEG, specifically "MozJPEG", with a typical file size reduction of 70% to 80% without a noticeable reduction in quality.

So I also wonder since JPEG is supported if it would be a better default file format because of the quality to file size ratio.