Closed kghbln closed 7 years ago
Thanks @kghbln do you have a live site I could see these on?
Thanks @kghbln do you have a live site I could see these on?
Now I have:
If you register there I could make you an admin.
Darn, I see what the issue is. I'll push out a fix tonight.
Fixed and closing. Part of the issue was the introduction of .mw-indicator class. Older versions of SMW automatically floated right. Please check from develop branch and reopen if needed.
@Hutchy68 Great! Semantic MediaWiki is working perfect now, however the Echo notification is now bellies up. :(
Of course it is :( I'll take a look.
Yikes, this will take a while. Something really weird going on. PS I hate echo ;-)
Yikes, this will take a while.
Yeah, if it was just some CSS voodoo but it looks like ... You should create an account and look at the user menu. Did not even report this. :|
You should create an account
It has all happened. Now contributor, admin and crat.
Thanks @kghbln
I know what the issue is with echo... the Echo Developers!
Echo 1_27 release Jun 2016
<a href="/wiki/Special:Notifications"
class="mw-echo-notifications-badge mw-echo-notification-badge-nojs
oo-ui-image-invert oo-ui-iconElement oo-ui-iconElement-icon oo-ui-icon-bell"
title="Your alerts">0
</a>
Echo 1_28 release Oct 2016
<a href="/wiki/Special:Notifications"
class="mw-echo-notifications-badge mw-echo-notification-badge-nojs"
data-counter-num="1"
data-counter-text="1"
title="Your alerts">1
</a>
<rant>
4 months later they have rewritten the whole output of the notification and messages. I'm starting to wonder if it is worth the time to have echo. The issue is, Echo developers do this:
Honestly, I think it is time for a decent Echo 3rd party fork or once and for all merge it into MW core and let the development of it be oversee by someone who knows what a b/c is.
</rant>
@Hutchy68 You are definitively not the only one with an issue here. Now that you are writing this I remember that Echo was rewritten for MW 1.28. What I did not have on my radar is that they oops did it again. :(
Completely disregard 3rd party wiki use
Indeed there are people around that seem to believe that sharing knowledge is only possible on WMF wikis. This is at least my conclusion form what I have seen. The scope of WMF's core mission however lies much beyond this narrow interpretation.
If you look on 1.28 now they have even changed the div ID from -messages to -notices. Why? IMHO that's the equivalent to core changing mw-content to mw-pagecontent to mw-content-of-page. They all mean the same thing but they don't programmatically.
Whoever the lead developer is does not know the meaning of backwards compatibility nor do they understand the meaning of breaking changes.
At this point I don't even know if I can write anything that's going to be compatible for someone who's using 1.27 versus someone using 1.28.
O_o
At this point I don't even know if I can write anything that's going to be compatible for someone who's using 1.27 versus someone using 1.28.
Here I'd personally prefer 1.27 since this is LTS. Given the changes I'd start to worry about new versions as soon as MW 1.30-alpha is around. At the same time the docu should probably emphasize the focus on LTS versions.
The only reason why sandbox is on MW 1.28 is to help SMW somehow cope with newer releases since it is one of the most popular extensions to MediaWiki. One the other hand: Forgeground as a skin has gotten pretty important nowadays too so not caring about regular releases of MW and the most popular extensions to it may not be a good idea after all.
@kghbln Could you pull down the changes to the develop branch. This is going to be a process. I will have to setup a dedicated 1.28 with echo installed eventually but this is the start of looking at how to fix it. Ugh!
Could you pull down the changes to the develop branch.
Done!
Thanks @kghbln
If you are still awake, the develop branch has one more update which I think will make 1.28 and 1.27 work.
If you are still awake
No, was already in sleepy land. Updated now.
I think will make 1.28 and 1.27 work.
Better but not quite, at least for 1.28+
I found the problem, duplicate CSS. I need to go over the CSS file for foreground. Maybe time to break it up.
One more time, pull down develop branch. 🤞
One more time, pull down develop branch. :crossed_fingers:
Done!
So close!
So close!
Yay! :) Thanks a lot for your effort!
Setup
Issue Semantic MediaWiki comes with usage count indicators which are misaligned on Foreground. So far I have not figured out how to fluff them.
Screenshot