jthingelstad / foreground

A MediaWiki skin that focuses on putting your content in the foreground.
http://foreground.wikiproject.net/
Other
137 stars 60 forks source link

Visual Editor visual issues with MW 1.35 #381

Open dhowland opened 3 years ago

dhowland commented 3 years ago

Setup

Issue

Fresh mediawiki install. Edit page with VE. Edit bar is out of whack.

Screenshot https://i.imgur.com/NhZhGIP.png

I think it might have something to do with the tutorial blurbs that show up when you first start editing.

Hutchy68 commented 3 years ago

No, it was the previous fixes needed to make VE work with the skin. Seems as if VE now has targeted their CSS properly so the fixes are not needed any longer. In short, they are conflicting.

I will push a fix as soon as @jthingelstad looks at CircleCI and turn on its integration or let me know he's wants to stick with Travis-CI. I have updated my fork to stop using Travis-CI, start using CircleCI, and other improvements to testing. Travis-CI has basically become un-useable for open source project unless you have a paid account. This all started around Nov 2, 2020.

dhowland commented 3 years ago

Ok thanks.

Would it be appropriate to have some kind of light box around the editing window? I ask because the nature of this skin makes footers and any other wiki stuff indistinguishable from article content.

jthingelstad commented 3 years ago

I will push a fix as soon as @jthingelstad looks at CircleCI and turn on its integration

Done! 😄

Hutchy68 commented 3 years ago

Ok, the fix is pushed to the develop branch for the VE toolbar.

Would it be appropriate to have some kind of light box around the editing window? I ask because the nature of this skin makes footers and any other wiki stuff indistinguishable from article content.

Let's all look at that first. You can try to add this to a MediaWiki message, create the page MediaWiki:Foreground.css then cut and paste the following into that new system message.

.ve-init-mw-desktopArticleTarget-originalContent {
    border-bottom: 2px solid #c8ccd1;
    padding: 15px 0;
}

*Note - I had a few issues with MW 1.35 and system message. 1.35 is still buggy IMHO. The page was in a loop on saving until I deleted the last bracket and then manually typed it in. Then I was allowed to save the page, MediaWiki:Foreground.css. So much for the easy cut and paste. I am finding changing the skin preference buggy too. Multiple tries until it takes. That's all MW so I guess I need to see if there are bugs reported about these issues yet.