Open keepersdungeon opened 3 years ago
Same Versions, same Problem. And the Action Menu does not open.
Loaded today from https://github.com/thingles/foreground/archive/develop.zip
In Browser Console apear the following errors. Do not exist, if foreground is not the default skin.
load.php?lang=de&modules=jquery%2Csite|jquery.client%2Ccookie|mediawiki.String%2CTitle%2Capi%2Cbase%2Ccldr%2CjqueryMsg%2Clanguage%2Cutil|mediawiki.libs.pluralruleparser|mediawiki.page.ready|mediawiki.page.watch.ajax|skins.foreground.js%2Cmodernizr|user.defaults&skin=foreground&version=1r0yl:52 jQuery.Deferred exception: url.indexOf is not a function TypeError: url.indexOf is not a function
at jQuery.fn.init.jQuery.fn.load (https://foo.bar/load.php?lang=de&modules=jquery%2Csite%7Cjquery.client%2Ccookie%7Cmediawiki.String%2CTitle%2Capi%2Cbase%2Ccldr%2CjqueryMsg%2Clanguage%2Cutil%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%7Cmediawiki.page.watch.ajax%7Cskins.foreground.js%2Cmodernizr%7Cuser.defaults&skin=foreground&version=1r0yl:138:28)
at Object.events (https://foo.bar/load.php?lang=de&modules=jquery%2Csite%7Cjquery.client%2Ccookie%7Cmediawiki.String%2CTitle%2Capi%2Cbase%2Ccldr%2CjqueryMsg%2Clanguage%2Cutil%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%7Cmediawiki.page.watch.ajax%7Cskins.foreground.js%2Cmodernizr%7Cuser.defaults&skin=foreground&version=1r0yl:273:485)
at HTMLElement.bind (https://foo.bar/load.php?lang=de&modules=jquery%2Csite%7Cjquery.client%2Ccookie%7Cmediawiki.String%2CTitle%2Capi%2Cbase%2Ccldr%2CjqueryMsg%2Clanguage%2Cutil%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%7Cmediawiki.page.watch.ajax%7Cskins.foreground.js%2Cmodernizr%7Cuser.defaults&skin=foreground&version=1r0yl:258:197)
at Function.each (https://foo.bar/load.php?lang=de&modules=jquery%2Csite%7Cjquery.client%2Ccookie%7Cmediawiki.String%2CTitle%2Capi%2Cbase%2Ccldr%2CjqueryMsg%2Clanguage%2Cutil%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%7Cmediawiki.page.watch.ajax%7Cskins.foreground.js%2Cmodernizr%7Cuser.defaults&skin=foreground&version=1r0yl:5:278)
at jQuery.fn.init.each (https://foo.bar/load.php?lang=de&modules=jquery%2Csite%7Cjquery.client%2Ccookie%7Cmediawiki.String%2CTitle%2Capi%2Cbase%2Ccldr%2CjqueryMsg%2Clanguage%2Cutil%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%7Cmediawiki.page.watch.ajax%7Cskins.foreground.js%2Cmodernizr%7Cuser.defaults&skin=foreground&version=1r0yl:3:93)
at Object.bindings (https://foo.bar/load.php?lang=de&modules=jquery%2Csite%7Cjquery.client%2Ccookie%7Cmediawiki.String%2CTitle%2Capi%2Cbase%2Ccldr%2CjqueryMsg%2Clanguage%2Cutil%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%7Cmediawiki.page.watch.ajax%7Cskins.foreground.js%2Cmodernizr%7Cuser.defaults&skin=foreground&version=1r0yl:258:327)
at Object.init (https://foo.bar/load.php?lang=de&modules=jquery%2Csite%7Cjquery.client%2Ccookie%7Cmediawiki.String%2CTitle%2Capi%2Cbase%2Ccldr%2CjqueryMsg%2Clanguage%2Cutil%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%7Cmediawiki.page.watch.ajax%7Cskins.foreground.js%2Cmodernizr%7Cuser.defaults&skin=foreground&version=1r0yl:268:207)
at Object.init_lib (https://foo.bar/load.php?lang=de&modules=jquery%2Csite%7Cjquery.client%2Ccookie%7Cmediawiki.String%2CTitle%2Capi%2Cbase%2Ccldr%2CjqueryMsg%2Clanguage%2Cutil%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%7Cmediawiki.page.watch.ajax%7Cskins.foreground.js%2Cmodernizr%7Cuser.defaults&skin=foreground&version=1r0yl:263:71)
at Object.init (https://foo.bar/load.php?lang=de&modules=jquery%2Csite%7Cjquery.client%2Ccookie%7Cmediawiki.String%2CTitle%2Capi%2Cbase%2Ccldr%2CjqueryMsg%2Clanguage%2Cutil%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%7Cmediawiki.page.watch.ajax%7Cskins.foreground.js%2Cmodernizr%7Cuser.defaults&skin=foreground&version=1r0yl:262:250)
at HTMLDocument.
Same issue. Actions
menu does no longer open in mediawiki 1.37.1
.
Same problem on latest mediawiki (updated due security problems)
MediaWiki | 1.37.1 PHP | 7.4.27 (apache2handler) MariaDB | 10.1.41-MariaDB-0ubuntu0.18.04.1 ICU | 65.1
Same problem when upgrading to 1.37.1 Too bad because it's a great skin.
When I have time I will try to look into this issue.
The problem is MW devs seem to be breaking stuff with each release now. Used to be at a minimum they would deprecate, warn then remove, based around a LTS. Issues were addressed in 1.31, then 1.35, now 1.37?!? You could at least go through 2 LTS releases and develop at a pace. Now they are breaking stuff with short term releases! That’s stupid with a capital S.
This skin started with usability in 1.21 all the way to 1.30 without issues.
Thank you, much appreciated.
Having done a bit of investigation, it appears that there is a conflict between the window.load
function declared in this code's function bindLoad ()
and jquery's load
function. If you change the name of the function to something less generic than load
, it should fix the problem.
Having done a bit of investigation, it appears that there is a conflict between the
window.load
function declared in this code'sfunction bindLoad ()
and jquery'sload
function. If you change the name of the function to something less generic thanload
, it should fix the problem.
Hi, thanks for this information. I tried but with no success... Maybe I did something wrong.. Could you please give the files and parts of code to modify to make it work ?
Thank you very much,
Etienne
Ok sorry, the patch commited by mecirt works great : https://github.com/jthingelstad/foreground/pull/394/commits/82bbd1539eb628882eeaff8b8f16bcc2e50d098f
I'm very happy ! Many thanks, this skin is really great !
Setup
Issue
Theme broken with mw 1.37.0 sidebar menue doesn't work anymore