jthomasmock / gtExtras

A Collection of Helper Functions for the gt Package.
https://jthomasmock.github.io/gtExtras/
Other
195 stars 27 forks source link

Improved inheritance of `scales::col_numeric` params #1

Closed mrcaseb closed 3 years ago

mrcaseb commented 3 years ago

NOTE: currently an alpha argument would be passed on to scales::col_numeric which describes the argument as

Whether alpha channels should be respected or ignored. If TRUE then colors without explicit alpha information will be treated as fully opaque.

It would also be possible to pass an alpha argument to gt::data_color which describes the argument as

An optional, fixed alpha transparency value that will be applied to all of the colors provided (regardless of whether a color palette was directly supplied or generated through a color mapping function).

I think you need to decide what your alpha should do.

mrcaseb commented 3 years ago

Adding back domain also fixes this grafik

jthomasmock commented 3 years ago

I was missing inherit dot params - thank you!