Closed mrcaseb closed 2 years ago
Notes:
Hey @mrcaseb - thanks! The R Cmd Check notes are plentiful - got a bit of work to do on my end before CRAN 😉
There was also an open request for dynamically setting the colors (ie by team), so I'll sit on this PR for a little bit.
Sidenote: @guga31bb wrote a helper function that creates a script to silence check notes on tidy evaluation.
https://github.com/guga31bb/ngscleanR/blob/master/data-raw/generate_silence_eval_notes.R
You might want to use it.
@jthomasmock I have merged the current master into the PR.
However, now all checks are failing because the remote repository for the non CRAN dependency webshot2 is missing. Additionally I highly recommend switching to v2 of some r-lib actions. I can fix the above mentioned stuff but I am unsure how many changes you want in this PR. So I'll keep it as is for now and wait for your answer.
Currently the colors argument is directly used in the html string that creates the merged and stacked cells. Since some R colornames are not known in html they won't work at all. See
This updated translates the colornames to hcl with scales. This allows non html colornames that are built-in to R. Above code will output this: