search

jthomperoo / predictive-horizontal-pod-autoscaler

Horizontal Pod Autoscaler built with predictive abilities using statistical models
Apache License 2.0
330 stars 30 forks source link

Custom Pod Autoscaler does not integrate with Argo Rollouts #52

Closed MarahAbu closed 2 years ago

MarahAbu commented 2 years ago

Describe the bug custom pod autoscaler does not integrate with argo rollouts.

To Reproduce using argo rollouts

Expected behavior I added rollouts under rules.resources and added argoproj.io under rules.apiGroups in Role I thought it would fix the issue, but still I got: 'no kind "Rollout" is registered for version "argoproj.io/v1alpha1" ' in custom pod autoscaler logs.

Kubernetes Details (kubectl version): v1.19.8

Additional context can you please add argo rollouts support?

jthomperoo commented 2 years ago

Hey, thanks for raising this, I think this will require work to the underlying Custom Pod Autoscaler that this is built ontop of - I'll investigate and create an issue under that repository so we can hopefully add these changes in soon. I'll keep this issue updated with any changes. Thanks!

amitde69 commented 2 years ago

any updates on this one ?

jthomperoo commented 2 years ago

Hey, sorry had a look at implementing this, hit into this issue reported here: argoproj/argo-workflows#6750. It seems that the Argo client doesn't play nice with K8s clients v0.21+ which unfortunately this project uses (older versions are deprecated). I think this will be blocked until that's done, but the actual work looks like it could be simple enough once that's done.

You can follow the work done on this for the Custom Pod Autoscaler (the base dependency of this project) here: https://github.com/jthomperoo/custom-pod-autoscaler/pull/152

After that the jthomperoo/horizontal-pod-autoscaler and jthomperoo/predictive-horizontal-pod-autoscaler would need to be updated, but those should be minor changes.

jthomperoo commented 2 years ago

Perhaps not actually blocked by above, downgrading to K8s client v0.21.8 seems to work. Will try and get a build that hopefully anyone that wants to use this could test out for me.

jthomperoo commented 2 years ago

This is now available in the v0.9.0 release, I've tested as much as I can but have somewhat limited experience with Argo Rollouts - if you can try it out and raise any bugs as issues that would be much appreciated.

There's an example that could help out here: https://github.com/jthomperoo/predictive-horizontal-pod-autoscaler/tree/v0.9.0/examples/argo-rollout

Thanks!