search

jthomperoo / predictive-horizontal-pod-autoscaler

Horizontal Pod Autoscaler built with predictive abilities using statistical models
Apache License 2.0
330 stars 30 forks source link

Add ability to specify start time #81

Closed jthomperoo closed 1 year ago

jthomperoo commented 1 year ago

Is your feature request related to a problem? Please describe.

In the move from PHPA v0.10.0 to v0.11.0 the PHPA was changed to no longer be based on the Custom Pod Autoscaler framework. This meant that there was no longer in built support for the startTime field, which was very useful for using season based models such as Holt-Winters (e.g. define a season as a single day, starting at midnight).

BREAKING CHANGE: Since no longer built as a CustomPodAutoscaler the startTime configuration is no longer available: https://custom-pod-autoscaler.readthedocs.io/en/latest/reference/configuration/#starttime.

Describe the solution you'd like It would be good if this functionality was implemented directly in the PHPA again.

Since we probably still want a functional autoscaler before this start time, the only thing that could change would be that models would only start applying after the start time, but data would still be gathered and normal HPA operations would occur.

Describe alternatives you've considered N/A

Additional context N/A

jthomperoo commented 1 year ago

This is available in release v0.13.0.