Closed akiradeveloper closed 4 years ago
akiradeveloper
commented
9 years ago .ruby-version file is only used by rbenv which is a ruby manager that I am using.
It was my mistake to commit it. The content of the file differs accross environments so this shouldn't be commited.
akiradeveloper
commented
9 years ago Sorry, I may have said the wrong thing. I am not sure who committed the .ruby-version file but it's true it shouldn't be in the repository. For example, the content is 1.9.3-p545 in my machine.
jthornber
commented
9 years ago I do want to tie it down to a specific ruby version (patch level doesn't matter).
On Mon, 11 May 2015 at 16:23 Akira Hayakawa notifications@github.com wrote:
Sorry, I may have said the wrong thing. I am not sure who committed the .ruby-version file but it's true it shouldn't be in the repository. For example, the content is 1.9.3-p545 in my machine.
— Reply to this email directly or view it on GitHub https://github.com/jthornber/device-mapper-test-suite/pull/44#issuecomment-100942859 .
akiradeveloper
commented
9 years ago I remove it because I need to stash/stash pop the file everytime I commit and this is really bothering me.
How about placing version check in the ruby code like
if RUBY_VERSION != 1.9.3 puts "ruby version must be 1.9.3" exit end
The check will work because RUBY_VERSION doesn't have pXXX
irb(main):001:0> RUBY_VERSION => "1.9.3" $ ruby -v ruby 1.9.3p545 (2014-02-24 revision 45159) [x86_64-linux]
On 2015/05/12 0:32, Joe Thornber wrote:
I do want to tie it down to a specific ruby version (patch level doesn't matter).
On Mon, 11 May 2015 at 16:23 Akira Hayakawa notifications@github.com wrote:
Sorry, I may have said the wrong thing. I am not sure who committed the .ruby-version file but it's true it shouldn't be in the repository. For example, the content is 1.9.3-p545 in my machine.
— Reply to this email directly or view it on GitHub https://github.com/jthornber/device-mapper-test-suite/pull/44#issuecomment-100942859 .
Reply to this email directly or view it on GitHub: https://github.com/jthornber/device-mapper-test-suite/pull/44#issuecomment-100947310
jthornber
commented
9 years ago Because RVM uses that file to automatically use the correct version.
On Mon, 11 May 2015 at 16:46 Akira Hayakawa notifications@github.com wrote:
I remove it because I need to stash/stash pop the file everytime I commit and this is really bothering me.
How about placing version check in the ruby code like
if RUBY_VERSION != 1.9.3 puts "ruby version must be 1.9.3" exit end
The check will work because RUBY_VERSION doesn't have pXXX
irb(main):001:0> RUBY_VERSION => "1.9.3" $ ruby -v ruby 1.9.3p545 (2014-02-24 revision 45159) [x86_64-linux]
On 2015/05/12 0:32, Joe Thornber wrote:
I do want to tie it down to a specific ruby version (patch level doesn't matter).
On Mon, 11 May 2015 at 16:23 Akira Hayakawa notifications@github.com wrote:
Sorry, I may have said the wrong thing. I am not sure who committed the .ruby-version file but it's true it shouldn't be in the repository. For example, the content is 1.9.3-p545 in my machine.
— Reply to this email directly or view it on GitHub < https://github.com/jthornber/device-mapper-test-suite/pull/44#issuecomment-100942859
.
Reply to this email directly or view it on GitHub:
https://github.com/jthornber/device-mapper-test-suite/pull/44#issuecomment-100947310
— Reply to this email directly or view it on GitHub https://github.com/jthornber/device-mapper-test-suite/pull/44#issuecomment-100952116 .
akiradeveloper
commented
9 years ago Well, so the 1.9.3 for RVM implicitly means the head of 1.9.3 series.
Don't you like the idea of adding version check in ruby code and still want to keep the file? If so, I will drop the commit.
jthornber
commented
9 years ago I would like to keep the file please
On Mon, 11 May 2015 at 17:11 Akira Hayakawa notifications@github.com wrote:
Well, so the 1.9.3 for RVM implicitly means the head of 1.9.3 series.
Don't you like the idea of adding version check in ruby code and still want to keep the file? If so, I will drop the commit.
— Reply to this email directly or view it on GitHub https://github.com/jthornber/device-mapper-test-suite/pull/44#issuecomment-100962790 .
akiradeveloper
commented
9 years ago OK. I dropped the commit.
Why did you remove the .ruby-version?
On Mon, 11 May 2015 at 16:03 Akira Hayakawa notifications@github.com wrote: