search

jtilander / niftyplugins

Visual Studio productivity plugins
MIT License
40 stars 24 forks source link

NiftyPerforce - VS 2019 Compatibility #115

Open jgvincen opened 5 years ago

jgvincen commented 5 years ago

Added support for building/running Nifty Perforce with Visual Studio 2019. Added partial support for loading the Nifty Perforce extension in the background.

jtilander commented 5 years ago

Looks great. Terribly sorry though, my employer prevents me from doing any open source.

jgvincen commented 5 years ago

I understand, I wouldn't want to make trouble. Are you allowed to approve/reject code changes which you didn't write?

benh57 commented 5 years ago

Works4Me. Perhaps @belkiss could merge?

belkiss commented 5 years ago

Works4Me. Perhaps @belkiss could merge?

Heya! I can't merge this here since I don't have permissions :) My fork https://github.com/belkiss/niftyplugins has had support for vs2019 for a while now, but I didn't make the changes for async load, so I'll try and integrate those changes there!

Thanks for the heads-up :)

akamboj commented 5 years ago

Hey @belkiss! If it's not a ton of trouble could you make a new release with all your fixes in it? I'd super appreciate it

belkiss commented 5 years ago

I've integrated the changes, they work great! https://github.com/belkiss/niftyplugins/commit/3e27df8da017a462136384d5835b66845225002d

Hey @belkiss! If it's not a ton of trouble could you make a new release with all your fixes in it? I'd super appreciate it

I'll try and setup the CI so we can release vsix, I'll keep you posted :)

jgvincen commented 5 years ago

Glad to hear that someone picked up my change. So, I guess @belkiss's fork has become the unofficial new mainline?