jtilander / niftyplugins

Visual Studio productivity plugins
MIT License
40 stars 24 forks source link

NiftyPerforce is not using proxy server. #75

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
(probably, I'm fairly new to NiftyPerforce)
1. Use a perforce proxy.
2. Use any option in NiftyPerforce that isn't EditItem
3. It will complain about being unable to connect to the actual server name, 
despite P4PORT being set to the proxy's address.

What is the expected output? What do you see instead?
I would have expected it to use the information in P4PORT, it seems to be 
getting data from p4 info.
p4 info reports as the server the server that the proxy is connected to.
you can tell from p4 info that you're connecting via a proxy if there is a 
Proxy version string present.
The "Determining if your Perforce client is using the proxy" section here has 
some info: http://www.perforce.com/perforce/r10.2/manuals/p4sag/09_p4p.html

What version of the product are you using? On what operating system?
NiftyPerforce.dll compiled on 09/10/2011 20:34:32
Visual studio 2010
Windows 7

Please provide any additional information below.

Original issue reported on code.google.com by gir...@gmail.com on 14 Dec 2011 at 4:01

GoogleCodeExporter commented 9 years ago
I can get round it by using the the config dialog to force the server to be the 
proxy, so it's not that big a deal.

I might attempt to make some kind of patch for this, I think I can see where a 
change could be made. 
My thought is that here:
http://code.google.com/p/niftyplugins/source/browse/trunk/NiftyPerforce/P4Operat
ions.cs#284
It ought to either get the data from 'p4 set' and/or from the P4PORT env var, 
rather than 'p4 info', falling back to p4 info if nothing else is found.

Original comment by gir...@gmail.com on 14 Dec 2011 at 5:06