jtilander / niftyplugins

Visual Studio productivity plugins
MIT License
40 stars 24 forks source link

NiftyPerfoce crashes VS when P4CLIENT is empty #89

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. start vs
2. fill in connection variables except for client, see http://snag.gy/0tW2O.jpg
3. attempt to checkout a file 

What is the expected output? 
do you even need the workspace name to edit a file?  
the examples on 
http://www.perforce.com/perforce/doc.current/manuals/cmdref/edit.htm dont 
specify a workspace name.  if you do need one there should be an error in the 
output window.  if you dont need one then the file should be checked out 
successfully.

What do you see instead?
Visual Studio crashes

What version of the product are you using? On what operating system?
NiftyPerforce 1.3.9.  Visual Studio 2010. Windows 7 Enterprise x64

Please provide any additional information below.

Original issue reported on code.google.com by JoshBoug...@gmail.com on 13 Jun 2012 at 5:45

GoogleCodeExporter commented 9 years ago
Correct link: 
http://www.perforce.com/perforce/doc.current/manuals/cmdref/edit.html

The workspace name is required, and is documented under g-opts: 
http://www.perforce.com/perforce/doc.current/manuals/cmdref/o.gopts.html

If it is not specified on the command line, p4 will fall back to the P4CLIENT 
variable will precedence rules as described in the docs for p4 set: 
http://www.perforce.com/perforce/doc.current/manuals/cmdref/set.html

The crash is probably a dupe of Issue 88.

Original comment by timbojo...@timbojones.net on 20 Jun 2012 at 10:41

GoogleCodeExporter commented 9 years ago
Believed fixed in 1.4.0

Original comment by jim.tila...@gmail.com on 15 Sep 2012 at 4:45