search

jtl-elisa / HUB-Awesome-Dungeon

1 stars 0 forks source link

move advancements in bundle #8

Open purejosh opened 2 years ago

purejosh commented 2 years ago

In largely modified servers, having too many advancements is already an issue that we need to install another mod to fix. This mod, and I'm assuming its nether and end sister versions, include a rain and thundering variation for the advancements.

I personally vote that they be removed.

Having too many advancements causes issues with larger than normal packets on login, even after installing an advancement fix mod, which can cause issues everywhere. For example, proxies like velocity will refuse a login for too large of a packet.

I suppose a config to allow us to disable advancements of these types, or even all advancements from this mod would be okay, but in my opinion, the rain and thundering variants of the advancements are pointless to have and cause more harm than good.

Sorry if this is "rough to hear", but I want to help this mod be better for everyone.

purejosh commented 2 years ago

Completed? What happened?

jtl-elisa commented 2 years ago

in consideration

purejosh commented 2 years ago

Oh okay, gotcha.

jtl-elisa commented 2 years ago

Should be implemented by the next update.

The solution: remove the "superfluous" advancements and provide them in a modular version. People who want more advancements will have to install the extra package that adds the "superfluous" advancements . The main version will contain only the basic advancements.

If you have other quality suggestions, don't hesitate! Thanks you for your feedback.

purejosh commented 10 months ago

I don't know why this was assigned to me.

jtl-elisa commented 10 months ago

I don't know why this was assigned to me.

Me too ^^ my bad ... But this task has not been abandoned :)