jtl-software / connector-woocommerce3

GNU Lesser General Public License v3.0
5 stars 6 forks source link

creation of variations is buggy when variations have special name #7

Closed kinglouie closed 2 years ago

kinglouie commented 3 years ago

I have found a weird issue, when I create product variations in JTL by the attribute name "Name" the variations are not visible in the woocommerce frontend and backend, however in the B2B market plugin I can see that there are variations created for which I can enter special prices. When I delete the variations in JTL, rename the attribute to something else and recreate them, the sync works as expected.

Am on the latest connector version and Woocommerce 5.0

Screenshot for how to reproduce 2021-03-04-083734_275x108_scrot

kinglouie commented 3 years ago

I think I also found the root issue: It is because woocommerce does not allow to create a product taxonomy where the slug is "name". When I manually create a taxonomy i can sucessfully add a taxonomy called "Name" when I set the slug to something like "name1". I think it would be nice if the connector plugin either reports an error if the taxonomy could not be created or even better it would detect if the default sanitized slug is rejected and appends something like "-1" to it so it won't be rejected.

paprykasz commented 3 years ago

Hey @kinglouie,

thank you for your feedback. We need to verify this issue first and then we will decide how we can handle it. Let me know if you have any questions.

All the best, Patryk

paprykasz commented 2 years ago

Implemented in 1.35.0