search

jtleek / papr

Paper app
19 stars 16 forks source link

Add swiping capability to facilitate more tactilely pleasing snap judgements #1

Closed LucyMcGowan closed 8 years ago

LucyMcGowan commented 8 years ago
jtleek commented 8 years ago

Ok first of all you two are freaking awesome for doing this!

Second of all - I'm having trouble getting the swipe to work. The app loads and everything but I can't "swipe" will it only work on mobile?

LucyMcGowan commented 8 years ago

yikes! It works on my laptop -- the "swipe region" is over the abstract -- is that where you are swiping?

jtleek commented 8 years ago

How many fingers were you using to swipe?

On Tue, Oct 4, 2016 at 4:21 PM LucyMcGowan notifications@github.com wrote:

yikes! It works on my laptop -- the "swipe region" is over the abstract -- is that where you are swiping?

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/jtleek/papr/pull/1#issuecomment-251501459, or mute the thread https://github.com/notifications/unsubscribe-auth/ABf7WsZiyScvD3j9B-FEuK33Tr9IMxJ9ks5qwrVbgaJpZM4KOGZK .

LucyMcGowan commented 8 years ago

One finger click & drag

jtleek commented 8 years ago

Ah! That works. Holy crap this is awesome!!!!

Have you tried it on mobile yet?

Can you do a few things to add to the pull request: (1) add yourselves as authors of the app on the about page with links to your websites, (2) add some swiping instructions to the main page (maybe right above where the paper is displayed it should say "click and swipe abstract to rate" or something? (3) change the instructions on the help page to reflect this new functionality?

Then I'll merge and push it to the papr website.

On Tue, Oct 4, 2016 at 4:22 PM LucyMcGowan notifications@github.com wrote:

One finger click & drag

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/jtleek/papr/pull/1#issuecomment-251501690, or mute the thread https://github.com/notifications/unsubscribe-auth/ABf7WsLozcEut5rvZkpf8ONmQho-Ck41ks5qwrWUgaJpZM4KOGZK .

LucyMcGowan commented 8 years ago

Yes! The swiping works on mobile, but if the abstract is too long you can't scroll -- I'm sure we can come up with a solution for that though.

Will do!

jtleek commented 8 years ago

Just waiting on this pull request until you folks give yourself credit etc. :)

LucyMcGowan commented 8 years ago

we got hung up looking for swipe icons :) maybe we can add later..

jtleek commented 8 years ago

If you add them later I'll merge that in too. I'm going to pusht he new version tomorrow morning and then announce it on twitter ok?

On Tue, Oct 4, 2016 at 10:19 PM LucyMcGowan notifications@github.com wrote:

we got hung up looking for swipe icons :) maybe we can add later..

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/jtleek/papr/pull/1#issuecomment-251565474, or mute the thread https://github.com/notifications/unsubscribe-auth/ABf7Wij-txib6aL5W9G_Y8w8amNHfn-Zks5qwwkegaJpZM4KOGZK .

LucyMcGowan commented 8 years ago

awesome -- thanks!

LucyMcGowan commented 8 years ago

I swapped out an icon to demonstrate swiping (demo: https://lucy.shinyapps.io/papr_swiper/) -- if you like it we can merge that in (I could go either way).