search

jtleek / rpackages

R package development - the Leek group way!
513 stars 287 forks source link

Should test-all.R be in tests rather than inst/tests ? #9

Closed jeromyanglim closed 10 years ago

jeromyanglim commented 10 years ago

Thanks for the awesome package writing guide. You suggest

To use the testthat package you will put a file called test-area-packagename.R in the > inst/tests directory, where area is the name of the broad class of functions you are testing. Then add another file called run-all.R in the same directory.

However, I noticed that this wasn't automatically running the tests when I ran R CMD CHECK in RStudio. I noticed that Hadley puts run-all.R in tests (e.g., stringr and puts the actual tests in inst/tests). When I did that, I had automated tests with R CMD CHECK.

jtleek commented 10 years ago

Awesome, thanks! Think you could update with a pull request correcting the problem and adding yourself to the list of contributors at the end of the document?

jeromyanglim commented 10 years ago

Hi Jeff,

Thanks again.

I've never done a pull request before. So that was good practice. Hopefully it worked.

cheers, Jeromy

... Dr Jeromy Anglim Lecturer in Research Methods School of Psychology, Deakin University website: http://jeromyanglim.blogspot.com

From: "Jeff L." notifications@github.com<mailto:notifications@github.com> Reply-To: jtleek/rpackages reply@reply.github.com<mailto:reply@reply.github.com> Date: Tuesday, 15 October 2013 11:06 AM To: jtleek/rpackages rpackages@noreply.github.com<mailto:rpackages@noreply.github.com> Cc: Jeromy Anglim jkanglim@gmail.com<mailto:jkanglim@gmail.com> Subject: Re: [rpackages] Should test-all.R be in tests rather than inst/tests ? (#9)

Awesome, thanks! Think you could update with a pull request correcting the problem and adding yourself to the list of contributors at the end of the document?

— Reply to this email directly or view it on GitHubhttps://github.com/jtleek/rpackages/issues/9#issuecomment-26299107.

Important Notice: The contents of this email are intended solely for the named addressee and are confidential; any unauthorised use, reproduction or storage of the contents is expressly prohibited. If you have received this email in error, please delete it and any attachments immediately and advise the sender by return email or telephone.

Deakin University does not warrant that this email and any attachments are error or virus free.