search

jtloong / chow_test

Python module to calculate time series Chow break statistics.
31 stars 11 forks source link

Patch 1 #1

Closed RUrlus closed 6 years ago

RUrlus commented 6 years ago

A few suggestions on how you could improve, testing needed though.

jtloong commented 6 years ago

Thanks for the feedback!

I will definitely make those changes. (Also if you check the README is that documentation for inputs okay or is there a better way to do that?)

RUrlus commented 6 years ago

Your welcome, good on you for putting it out there. It's good to have it there, but its nice to have in docstrings so that I can see it in my notebook or editor

jtloong commented 6 years ago

Hey I just edited the codebase with tests so that you can see it in use. Also I'm still navigating through proper docstring creation. Is what I've got now good to use?