search

jtojnar / nixfiles

Nix configuration for the machines I manage.
MIT License
60 stars 3 forks source link

activitywatch: unstable-2021-06-23 → 0.12.1 #8

Closed huantianad closed 1 year ago

huantianad commented 2 years ago

Updates dependencies, including rust unstable version and moves to qt6. Fixes for desktop file and icon installation, so it shows up in both the .desktop file and on the trayicon itself.

One thing of note is that I've manually patched the config hash to be equal to "EMPTY" (displayed in the webui for debugging purposes), perhaps there's a better way of doing this.

huantianad commented 1 year ago

Wanna double check on the commit hash thing and the autostart. Other than that, once you've looked over my other comments, everything should be good to squash and merge.

Also, aw-server-rust seems to build fine with rustPlatforms and the workaround you mentioned. I do want to tweak the tests so they work in the Nix sandbox though.

jtojnar commented 1 year ago

I think the version for the commit hash is fine, after all it should uniquely identify the VCS revision.

jtojnar commented 1 year ago

If you could squash and rebase, I think it is good to go. (Unfortunately GitHub’s Merge button will either add a pointless merge commit or make it so that the commit hashes in the PR do not match those in the merged tree.)

jtojnar commented 1 year ago

Thank you.