search

jtojnar / nixpkgs-hammering

Beat your package expressions into a shape
MIT License
241 stars 15 forks source link

`cmake` does not always imply `enableParallelBuilding = true` #101

Closed samuela closed 3 years ago

samuela commented 3 years ago

This issue is resultant from the discussion in https://github.com/NixOS/nixpkgs/pull/118000. In the julia derivations, cmake is used but the build is still serial. Adding enableParallelBuilding = true to the derivation does make the builds go parallel but it also triggers the unnecessary-parallel-building warning.

jtojnar commented 3 years ago

We should probably limit it to when dontUseCmakeConfigure is not true and configurePhase is not overridden.

On Wed, 31 Mar 2021 at 23:21, Samuel Ainsworth @.***> wrote:

This issue is resultant from the discussion in NixOS/nixpkgs#118000 https://github.com/NixOS/nixpkgs/pull/118000. In the julia derivations, cmake is used but the build is still serial. Adding enableParallelBuilding = true to the derivation does make the builds go parallel but it also triggers the unnecessary-parallel-building warning.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jtojnar/nixpkgs-hammering/issues/101, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFMEY4GMG4R6D7NQ2XYHVTTGOG53ANCNFSM42FSLMPQ .