search

jtojnar / nixpkgs-hammering

Beat your package expressions into a shape
MIT License
245 stars 14 forks source link

Deduplicate results #24

Open rmcgibbo opened 3 years ago

rmcgibbo commented 3 years ago

Running the unclear-gpl check against three packages that are all built from the same .nix file, in this case, can give 6 warning messages. We should probably de-duplicate by this down to 2, or ideally down to 1.

$ nix run -f ~/projects/nixpkgs-hammering -c  nixpkgs-hammer -f . -e attribute-ordering  libsForQt5.kio-extras libsForQt512.kio-extras libsForQt514.kio-extras 
When evaluating attribute ‘libsForQt5.kio-extras’:
warning: unclear-gpl
`gpl2` is a deprecated license, check if project uses `gpl2Plus` or `gpl2Only` and change `meta.license` accordingly.

Near /home/mcgibbon/projects/nixpkgs/pkgs/applications/kde/kio-extras.nix:12:5:
   |
12 |     license = with lib.licenses; [ gpl2 lgpl21 ];
   |     ^
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: unclear-gpl
`lgpl21` is a deprecated license, check if project uses `lgpl21Plus` or `lgpl21Only` and change `meta.license` accordingly.

Near /home/mcgibbon/projects/nixpkgs/pkgs/applications/kde/kio-extras.nix:12:5:
   |
12 |     license = with lib.licenses; [ gpl2 lgpl21 ];
   |     ^
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

When evaluating attribute ‘libsForQt512.kio-extras’:
warning: unclear-gpl
`gpl2` is a deprecated license, check if project uses `gpl2Plus` or `gpl2Only` and change `meta.license` accordingly.

Near /home/mcgibbon/projects/nixpkgs/pkgs/applications/kde/kio-extras.nix:12:5:
   |
12 |     license = with lib.licenses; [ gpl2 lgpl21 ];
   |     ^
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: unclear-gpl
`lgpl21` is a deprecated license, check if project uses `lgpl21Plus` or `lgpl21Only` and change `meta.license` accordingly.

Near /home/mcgibbon/projects/nixpkgs/pkgs/applications/kde/kio-extras.nix:12:5:
   |
12 |     license = with lib.licenses; [ gpl2 lgpl21 ];
   |     ^
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

When evaluating attribute ‘libsForQt514.kio-extras’:
warning: unclear-gpl
`gpl2` is a deprecated license, check if project uses `gpl2Plus` or `gpl2Only` and change `meta.license` accordingly.

Near /home/mcgibbon/projects/nixpkgs/pkgs/applications/kde/kio-extras.nix:12:5:
   |
12 |     license = with lib.licenses; [ gpl2 lgpl21 ];
   |     ^
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: unclear-gpl
`lgpl21` is a deprecated license, check if project uses `lgpl21Plus` or `lgpl21Only` and change `meta.license` accordingly.

Near /home/mcgibbon/projects/nixpkgs/pkgs/applications/kde/kio-extras.nix:12:5:
   |
12 |     license = with lib.licenses; [ gpl2 lgpl21 ];
   |     ^
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md