search

jtojnar / nixpkgs-hammering

Beat your package expressions into a shape
MIT License
245 stars 14 forks source link

Overleazous `unnecessary-parallel-building` check #25

Closed rmcgibbo closed 3 years ago

rmcgibbo commented 3 years ago

In pkgs/development/libraries/qt-5/mkDerivation.nix, I don't think we should be warning about that:

$ nix run -f ~/projects/nixpkgs-hammering/ -c nixpkgs-hammer -e attribute-ordering -e unclear-gpl lxqt.lxqt-runner
When evaluating attribute ‘lxqt.lxqt-runner’:
warning: unnecessary-parallel-building
Meson, CMake and qmake already set `enableParallelBuilding = true` by default so it is not necessary.

Near /home/mcgibbon/projects/nixpkgs/pkgs/development/libraries/qt-5/mkDerivation.nix:25:5:
   |
25 |     enableParallelBuilding = args.enableParallelBuilding or true;
   |     ^
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unnecessary-parallel-building.md
jtojnar commented 3 years ago

This should have gotten fixed in staging, see https://github.com/jtojnar/nixpkgs-hammering/issues/11.

rmcgibbo commented 3 years ago

Oh I see. Brilliant.