search

jtojnar / nixpkgs-hammering

Beat your package expressions into a shape
MIT License
245 stars 14 forks source link

unclear-gpl: False negative for “only” licenses #4

Closed jtojnar closed 3 years ago

jtojnar commented 3 years ago

We are comparing structurally and gpl3 == gpl3Only.

{ stdenv
}:

stdenv.mkDerivation {
  name = "unclear-gpl-gpl3-only";

  src = ../fixtures/make;

  meta.license = stdenv.lib.licenses.gpl3Only;
}
SuperSandro2000 commented 3 years ago

Is this related to 

When evaluating attribute ‘luna-icons’:                                                                                                                                                     warning: unclear-gpl                                                                                                                                                                        `gpl3` is a deprecated license, check if project uses `gpl3Plus` or `gpl3Only` and change `meta.license` accordingly.                                                                                                                                                                                                                                                                   Near /home/hotpi/.cache/nixpkgs-review/pr-107050/nixpkgs/pkgs/data/icons/luna-icons/default.nix:54:5:
   |
54 |     license = [ licenses.gpl3Only ];
   |     ^
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
jtojnar commented 3 years ago

Yes, that is this issue. https://github.com/NixOS/nixpkgs/pull/107417 will fix it.