Add way to disable checks if they are false positive

jtojnar / nixpkgs-hammering

Beat your package expressions into a shape

MIT License

245 stars 14 forks source link

Add way to disable checks if they are false positive #59

Open SuperSandro2000 opened 3 years ago

SuperSandro2000 commented 3 years ago

Some packages like ashuffle (https://github.com/NixOS/nixpkgs/pull/113413#issuecomment-781592026) would benefit if they could ignore some specific checks explicitly.

jtojnar commented 3 years ago

I wonder if the cmake usage is visible in logs. Or in the source code. Or we should require a comment next to cmake.

rmcgibbo commented 3 years ago

Here are the logs for that: https://gist.github.com/r-rmcgibbo/1e0725056d74a933ee6e2e9ee46dec04

I think it's probably tricky to reliably grab this information from the logs or the source code, but I'm not sure.

jtojnar commented 3 years ago

Executing subproject absl method cmake line is telling (we could have a test that the message did not change) . Otherwise we might try using mesonʼs introspection API.