search

jtojnar / nixpkgs-hammering

Beat your package expressions into a shape
MIT License
244 stars 14 forks source link

typo detection points to wrong position and should probably not trigger in inherit #60

Open SuperSandro2000 opened 3 years ago

SuperSandro2000 commented 3 years ago

The little ^ is at the wrong position and this should probably not be nitted at all.

See https://github.com/NixOS/nixpkgs/pull/113405#issuecomment-780798227

When evaluating attribute ‘gambit’:
warning: attribute-typo
A likely typo in `git-version` argument was found, did you mean `version`?
Near /home/hotpi/src/nixpkgs2/pkgs/development/compilers/gambit/build.nix:25:10:
|
25 |   inherit src version git-version;
|          ^                                                                                                                                                                             See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md
SuperSandro2000 commented 3 years ago 
agpl3 is a deprecated license, check if project uses agpl3Plus or agpl3Only and change meta.license accordingly.

Near pkgs/development/haskell-modules/generic-builder.nix:640:19:

────────────────────
    |
640 |   meta = { inherit homepage license platforms; }
    |                   ^
────────────────────

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

another example of the ^ being wrong. Package is bup.

jtojnar commented 3 years ago

builtins.unsafeGetAttrPos currently returns the location of the end of the inherit token for all inherited attributes. We would need to fix Nix or get the data from rnix somehow.