Fix #1 Close connection only when doc is closed

jtokoph / ghosttext-vscode

Use the new official extension: https://marketplace.visualstudio.com/items?itemName=fregante.ghost-text

https://marketplace.visualstudio.com/items?itemName=fregante.ghost-text

27 stars 11 forks source link

Fix #1 Close connection only when doc is closed #2

Closed mazamachi closed 6 years ago

mazamachi commented 7 years ago

Fix #1

When language setting is changed, the dispose event is triggered in VSCode, and thus onDidCloseTextDocument is fired. I changed to check if the document is closed.

@jtokoph, I would like you to review. Thanks.

ypresto commented 7 years ago

@jtokoph Please review this. This plugin is useful if highlighting is available! (Markdown or etc.) :)

timharris777 commented 6 years ago

@jtokoph : Has this been merged yet? Why is it taking so long to fix this?

Arrow7000 commented 6 years ago

Could someone please merge this? 🙏

Currently because of this bug I can only type without syntax highlighting, which completely negates the point of using an editor.

This would be a gamechanger!

jtokoph commented 6 years ago

Sorry for the super long delay. I've been neglecting all of github for a while. This should be live now.