search

jtorchat / jtorchat-old

Academic, Java, p2p, Messaging, Messenger, cyptography
21 stars 12 forks source link

Buddy removing is broken. #29

Closed meh closed 12 years ago

meh commented 12 years ago

When I send a _removeme packet I get back a _notimplemented and grepping for remove_me in the tree doesn't get me anything.

Did you forget to implement buddy removal?

ghost commented 12 years ago

Come this message from a jtorchat or a torchat client. In both scenarios it is bad but only when it come from a jtorchat client is it a bug. I will add this when it is not implemented now in the next version

meh commented 12 years ago

The connection on your side also seems to end up in a weird status where it keeps sending me the previous cookie instead of the right one.

[2012-04-25 17:07:53 +0200] ping incoming from claimed 77rk5ecwyfzhqohm
[2012-04-25 17:07:53 +0200] connecting to 77rk5ecwyfzhqohm.onion:11009
[2012-04-25 17:07:53 +0200] 77rk5ecwyfzhqohm pong with wrong cookie, got "718e6da5-3fda-465f-82ff-82ec915f6984" expected nil
[2012-04-25 17:07:54 +0200] >> 77rk5ecwyfzhqohm #<Torchat::Packet[ping]: 7acbk6jpofsanyfp e77cac07-5d83-4e86-9346-cd22d242196b>
[2012-04-25 17:07:54 +0200] 77rk5ecwyfzhqohm connected
[2012-04-25 17:08:20 +0200] 77rk5ecwyfzhqohm disconnected
[2012-04-25 17:08:53 +0200] ping incoming from claimed 77rk5ecwyfzhqohm
[2012-04-25 17:08:53 +0200] 77rk5ecwyfzhqohm pong with wrong cookie, got "e77cac07-5d83-4e86-9346-cd22d242196b" expected nil
[2012-04-25 17:08:53 +0200] connecting to 77rk5ecwyfzhqohm.onion:11009
[2012-04-25 17:08:56 +0200] >> 77rk5ecwyfzhqohm #<Torchat::Packet[ping]: 7acbk6jpofsanyfp 2fa255e1-fab6-4cc9-bbed-53121936b35d>
[2012-04-25 17:08:56 +0200] 77rk5ecwyfzhqohm connected
[2012-04-25 17:09:20 +0200] 77rk5ecwyfzhqohm disconnected

This are the relevant logs, as you can see it keeps sending the previous cookie and doesn't respond to the new ping from me.

meh commented 12 years ago

Come this message from a jtorchat or a torchat client. In both scenarios it is bad but only when it come from a jtorchat client is it a bug. I will add this when it is not implemented now in the next version

I'm not sure I understand what you said, but yes, jTorchat doesn't understand the _removeme packet which is part of the standard protocol and the only way to remove a buddy properly.

ghost commented 12 years ago

I mean is the contact on the other side jtorchat or torchat?

1) from jtorchat = bug 2) torchat feature not included now

meh commented 12 years ago

Yes, it's a jTorchat, JTC [T2] 0.7.8.

ghost commented 12 years ago

I will try to add this in the next Version.

ghost commented 12 years ago

I have added this and test it with meh. It works when we have a connection to both sides then both delete the buddy.