search

jtorchat / jtorchat-old

Academic, Java, p2p, Messaging, Messenger, cyptography
21 stars 12 forks source link

Improving readability and maintainability #6

Closed smithrachael closed 12 years ago

smithrachael commented 12 years ago

Hi,

As my first patch, I propose a few changes on the existing code in order to make it more readable and to make it easier to extend in the future.

Please take a look and send your comments.

See ya,

zerotamaitsu commented 12 years ago

thanks smithrachael.

jtorchat, can you make sure that the filetransfer fix by porlington was not overwritten? It was a pull request not too long ago by porlington

jtorchat commented 12 years ago

The fix from prolington is not in the code. He has no send a merge request, but i hope he do it. Before he can do that he must retrieve the new src and make a patch with them.

smithrachael commented 12 years ago

Yeah. With the new directory structure, any non-merged patch must be generated again.

On Sun, Apr 8, 2012 at 1:37 PM, jtorchat < reply@reply.github.com

wrote:

The fix from prolington is not in the code. He has no send a merge request, but i hope he do it. Before he can do that he must retrieve the new src and make a patch with them.

Reply to this email directly or view it on GitHub: https://github.com/jtorchat/jtorchat/pull/6#issuecomment-5015491