Fix pattern playback with a nonstandard length

jtothebell / fake-08

A Pico-8 player/emulator for console homebrew

Other

577 stars 48 forks source link

Fix pattern playback with a nonstandard length #109

Closed DPS2004 closed 2 years ago

DPS2004 commented 2 years ago

fixes https://github.com/jtothebell/fake-08/issues/89

jtothebell commented 2 years ago

Thank you for fixing this as well! I was looking at this one, and it looked like it was correct for music, and fixed rhythmfrog, but when I went to make a simple test cart that just played an sfx, it was still broken. So I basically implemented the same thing for sfx. It seems to match the pico 8 behavior. Attached is my minimal test cart example. Can you verify this works for you without any obvious regression as well? custom_length_sfx.p8.zip .

DPS2004 commented 2 years ago

Seems to work fine for me