search

jtothebell / fake-08

A Pico-8 player/emulator for console homebrew
Other
583 stars 50 forks source link

More robust fix for music master channel selection #171

Closed fringd closed 1 year ago

fringd commented 2 years ago

here's a more robust fix for music playing. This takes into account sfx length, sfx looping, sfx speed, and comes with some tests ^_^

confirmed it fixes my title song on this image and another song that was broken later on. Played a buncha random carts on my miyoo mini and it seemed good.

here's my cart that was not playing the whole song: planet p8

jtothebell commented 2 years ago

Thank you for this, and for adding some tests. I have only had time to take a quick look at it, and at first glance it looks like a good fix. With sound being the part of Pico-8 I understand the least, I'd like to take a closer look and do some manual testing to make sure there was no regression. I should have time to look closer in a couple of days.

fringd commented 2 years ago

thanks, and no rush. I'm excited for the work you're doing on running this as a retroarch core. I tried it out this build on miyoo mini with a few carts I'm familiar with and things sounded fine. I make a bit of music on pico-8, so maybe I can try to fix a few other things here and there.

fringd commented 2 years ago

did some manual testing in the real pico 8 and noticed one of these test cases was wrong. fixed the test and fixed the code.

fringd commented 1 year ago

take your time. i see you're working on having it as a retro arch core, which would be so sweet 🧁 On Sep 30, 2022, 10:59 PM -0400, Jon Bell @.***>, wrote:

Thank you for this, and for adding some tests. I have only had time to take a quick look at it, and at first glance it looks like a good fix. With sound being the part of Pico-8 I understand the least, I'd like to take a closer look and do some manual testing to make sure there was no regression. I should have time to look closer in a couple of days. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>