search

jtothebell / fake-08

A Pico-8 player/emulator for console homebrew
Other
583 stars 50 forks source link

Regressions in print #217

Closed DPS2004 closed 11 months ago

DPS2004 commented 11 months ago

In recent versions of FAKE-08 print has been behaving unexpectedly. To be specific:

I've narrowed down the double-width error to first occuring starting with this commit, and the palette bug starting with this commit.

Expected behavior: image Current behavior: image

Sorry if this was already known about, but I couldn't find an issue about it.

jtothebell commented 11 months ago

Thanks for reporting, I was not aware of these regressions. Those two cases should be fixed on master now. Hopefully there aren't any other regressions.

Side note, I find it hilarious that one of the repro cases was already in the test repo, but just wasn't wired up. While fixing this I put a bit of time into making those e2e tests not need to be manually wired up, but just pick up new carts/screenshots so hopefully that won't happen again after I finish that up.